Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create button visible in ACL list despite read-only mode #800

Open
4 tasks done
michael-follmann opened this issue Jan 24, 2025 · 1 comment
Open
4 tasks done

Create button visible in ACL list despite read-only mode #800

michael-follmann opened this issue Jan 24, 2025 · 1 comment
Labels
area/acl status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress type/bug Something isn't working

Comments

@michael-follmann
Copy link

Issue submitter TODO list

  • I've looked up my issue in FAQ
  • I've searched for an already existing issues here
  • I've tried running main-labeled docker image and the issue still persists there
  • I'm running a supported version of the application which is listed here

Describe the bug (actual behavior)

When I navigate to the ACL page in a cluster with active read-only mode, I can see a disabled "Create ACL" button. When I move my mouse over it, I can see the message "You don't have a required permission to perform this action".

Expected behavior

I expected this button not to be visible at all. This would be consistent with the lists for topics and schemas in read-only mode.

Your installation details

I'm using the Docker image ghcr.io/kafbat/kafka-ui:v1.1.0 and mount a application.yml file as volume to configure the application.

Steps to reproduce

  1. configure a Kafka cluster to have read-only mode
  2. navigate to the ACL list

Screenshots

Image

Logs

No response

Additional context

I could find this button in the code and don't see any isReadOnly checks as for other components:
https://github.com/kafbat/kafka-ui/blob/main/frontend/src/components/ACLPage/List/List.tsx#L153

I'm unsure if the following issue is related: #230

@michael-follmann michael-follmann added status/triage Issues pending maintainers triage type/bug Something isn't working labels Jan 24, 2025
@kapybro kapybro bot added area/acl status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 24, 2025
Copy link

Hi michael-follmann! 👋

Welcome, and thank you for opening your first issue in the repo!

Please wait for triaging by our maintainers.

As development is carried out in our spare time, you can support us by sponsoring our activities or even funding the development of specific issues.
Sponsorship link

If you plan to raise a PR for this issue, please take a look at our contributing guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/acl status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant