🐛 /etc/os-release with duplicated arguments when customizing disk image

[mauromorales]

When customizing a disk image for the RPi, the /etc/os-release file gets appended with the new info of the OS but it never cleans the previous arguments

wrong:

NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.17.3
PRETTY_NAME="Alpine Linux v3.17"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues"
KAIROS_NAME="kairos-core-alpine-arm-rpi"
KAIROS_VERSION="v2.0.2"
KAIROS_ID="kairos"
KAIROS_ID_LIKE="kairos-core-alpine-arm-rpi"
KAIROS_VERSION_ID="v2.0.2"
KAIROS_PRETTY_NAME="kairos-core-alpine-arm-rpi v2.0.2"
KAIROS_BUG_REPORT_URL="https://github.com/kairos-io/kairos/issues"
KAIROS_HOME_URL="https://github.com/kairos-io/kairos"
KAIROS_IMAGE_REPO="quay.io/kairos/core-alpine-arm-rpi"
KAIROS_IMAGE_LABEL="latest"
KAIROS_GITHUB_REPO="kairos-io/kairos"
KAIROS_VARIANT="core"
KAIROS_FLAVOR="alpine-arm-rpi"KAIROS_NAME="kairos-alpine-arm-rpi"
KAIROS_VERSION="v2.0.2-k3sv1.26.4+k3s1"
KAIROS_ID="kairos"
KAIROS_ID_LIKE="kairos-alpine-arm-rpi"
KAIROS_VERSION_ID="v2.0.2-k3sv1.26.4+k3s1"
KAIROS_PRETTY_NAME="kairos-alpine-arm-rpi v2.0.2-k3sv1.26.4+k3s1"
KAIROS_BUG_REPORT_URL="https://github.com/kairos-io/kairos/issues/new/choose"
KAIROS_HOME_URL="https://github.com/kairos-io/provider-kairos"
KAIROS_IMAGE_REPO="quay.io/kairos/kairos-alpine-arm-rpi"
KAIROS_IMAGE_LABEL="latest"
KAIROS_GITHUB_REPO="kairos-io/provider-kairos"
KAIROS_VARIANT="core"

Expected:

NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.17.3
PRETTY_NAME="Alpine Linux v3.17"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues"
KAIROS_NAME="kairos-alpine-arm-rpi"
KAIROS_VERSION="v2.0.2-k3sv1.26.4+k3s1"
KAIROS_ID="kairos"
KAIROS_ID_LIKE="kairos-alpine-arm-rpi"
KAIROS_VERSION_ID="v2.0.2-k3sv1.26.4+k3s1"
KAIROS_PRETTY_NAME="kairos-alpine-arm-rpi v2.0.2-k3sv1.26.4+k3s1"
KAIROS_BUG_REPORT_URL="https://github.com/kairos-io/kairos/issues/new/choose"
KAIROS_HOME_URL="https://github.com/kairos-io/provider-kairos"
KAIROS_IMAGE_REPO="quay.io/kairos/kairos-alpine-arm-rpi"
KAIROS_IMAGE_LABEL="latest"
KAIROS_GITHUB_REPO="kairos-io/provider-kairos"
KAIROS_VARIANT="core"

[jimmykarily]

There is more. Booting a release ubuntu provider image (https://github.com/kairos-io/provider-kairos/releases/download/v2.0.3/kairos-ubuntu-20-lts-v2.0.3-k3sv1.22.17+k3s1.iso) I get this:

root@localhost:~# cat /etc/os-release | grep opensuse
KAIROS_FLAVOR="opensuse-leap"

and this:

root@localhost:~# cat /etc/os-release | grep core
KAIROS_NAME="kairos-core-ubuntu-20-lts"
KAIROS_ID_LIKE="kairos-core-ubuntu-20-lts"
KAIROS_PRETTY_NAME="kairos-core-ubuntu-20-lts v2.0.3"
KAIROS_IMAGE_REPO="quay.io/kairos/core-ubuntu-20-lts"
KAIROS_VARIANT="core"
KAIROS_VARIANT="core"

This "append" bug could explain some of this but having opensuse in an ubuntu image is probably a different bug. I think when we call OSRELEASE target here: https://github.com/kairos-io/provider-kairos/blob/99b8b7c53c19779007790400e14ee2de57be6132/Earthfile#LL178C2-L178C2 we are not setting all the required env vars for this envsubst command:

kairos/Earthfile

Line 81 in 7eb0a42

RUN envsubst >>/etc/os-release </usr/lib/os-release.tmpl

thus some defaults are being used and they are set to opensuse. We need to fix that too.