Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPXE scripts in releases reference incorrect download URLs #1984

Closed
Tracked by #1978
jbalonso opened this issue Nov 5, 2023 · 2 comments · Fixed by #1986
Closed
Tracked by #1978

iPXE scripts in releases reference incorrect download URLs #1984

jbalonso opened this issue Nov 5, 2023 · 2 comments · Fixed by #1986
Assignees
Labels
bug Something isn't working prio: high

Comments

@jbalonso
Copy link
Contributor

jbalonso commented Nov 5, 2023

Release https://github.com/kairos-io/kairos/releases/tag/v2.4.0 includes the iPXE script https://github.com/kairos-io/kairos/releases/download/v2.4.0/kairos-standard-opensuse-tumbleweed-amd64-generic-v2.4.0-k3sv1.27.3+k3s1.ipxe, which includes the line:

kernel https://github.com/kairos-io/kairos/releases/download/v2.4.0-k3sv1.27.3+k3s1/kairos-standard-opensuse-tumbleweed-amd64-generic-v2.4.0-k3sv1.27.3+k3s1-kernel root=live:https://github.com/kairos-io/kairos/releases/download/v2.4.0-k3sv1.27.3+k3s1/kairos-standard-opensuse-tumbleweed-amd64-generic-v2.4.0-k3sv1.27.3+k3s1.squashfs initrd=kairos-standard-opensuse-tumbleweed-amd64-generic-v2.4.0-k3sv1.27.3+k3s1-initrd rd.neednet=1 ip=dhcp rd.cos.disable netboot nodepair.enable config_url= console=tty1 console=ttyS0 rd.live.overlay.overlayfs

It's a little hard to read, but the kernel URL is https://github.com/kairos-io/kairos/releases/download/v2.4.0-k3sv1.27.3+k3s1/kairos-standard-opensuse-tumbleweed-amd64-generic-v2.4.0-k3sv1.27.3+k3s1-kernel. You will get a 404 if you try to download it. Specifically, that URL contains the substring releases/download/v2.4.0-k3sv1.27.3+k3s1/, which has a superfluous -k3sv1.27.3+k3s1.

Note, moreover, that this superfluous substring appears multiple times throughout the script. Consequently this script (and the corresponding *.ipxe-usb.img asset, probably also the *.ipxe.iso one) are unusable.

@jbalonso jbalonso added the bug Something isn't working label Nov 5, 2023
@mauromorales mauromorales added the triage Add this label to issues that should be triaged and prioretized in the next planning call label Nov 6, 2023
@jimmykarily jimmykarily added prio: high and removed triage Add this label to issues that should be triaged and prioretized in the next planning call labels Nov 6, 2023
@jimmykarily jimmykarily moved this to Todo 🖊 in 🧙Issue tracking board Nov 6, 2023
@jimmykarily jimmykarily moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board Nov 6, 2023
@jimmykarily jimmykarily moved this from In Progress 🏃 to Todo 🖊 in 🧙Issue tracking board Nov 6, 2023
@jimmykarily jimmykarily mentioned this issue Nov 6, 2023
20 tasks
@mauromorales mauromorales moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board Nov 6, 2023
@mauromorales mauromorales self-assigned this Nov 6, 2023
@mauromorales
Copy link
Member

In 2.4.2 the issue is that the version is not present at all

https://github.com/kairos-io/kairos/releases/download//kairos-opensuse-leap-15.5-core-amd64-generic-v2.4.2-rc1-kerne

@mauromorales mauromorales moved this from In Progress 🏃 to Under review 🔍 in 🧙Issue tracking board Nov 6, 2023
@mauromorales
Copy link
Member

@jbalonso thanks a lot for the report 🙌

@github-project-automation github-project-automation bot moved this from Under review 🔍 to Done ✅ in 🧙Issue tracking board Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio: high
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants