Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uki: kairos-agent should check if an image is signed with compatible keys loaded on the system before upgrade #2421

Closed
nianyush opened this issue Apr 3, 2024 · 3 comments
Labels
enhancement New feature or request triage Add this label to issues that should be triaged and prioretized in the next planning call

Comments

@nianyush
Copy link

nianyush commented Apr 3, 2024

Right now, kairos-agent wont check it and go for an upgrade. After reboot, the device will enter into following state and user cannot recover it or reset but can only do in new install. So kairos-agent should throw an error instead of upgrade with wrong image
image

@nianyush nianyush added enhancement New feature or request triage Add this label to issues that should be triaged and prioretized in the next planning call labels Apr 3, 2024
@Itxaka
Copy link
Member

Itxaka commented Apr 3, 2024

I would even say that this is a bug rather than an enhancement as it's very easy to shoot yourself in the foot. Should be basic functionality.

Maybe we can use https://github.com/itxaka/go-secureboot which contains the talos secureboot libs extracted, when it's ready for generic consumption? It has functions related to signatures so maybe we can rework it to read signatures from files and confirm if they are enrolled in the current machine

@mudler
Copy link
Member

mudler commented Apr 3, 2024

duplicate of #2200 ?

@mudler
Copy link
Member

mudler commented Apr 3, 2024

closing as #2200 should cover this already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Add this label to issues that should be triaged and prioretized in the next planning call
Projects
Archived in project
Development

No branches or pull requests

3 participants