Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check tpm unlocking signatures are valid on upgrade #2598

Open
Itxaka opened this issue May 28, 2024 · 1 comment
Open

feat: check tpm unlocking signatures are valid on upgrade #2598

Itxaka opened this issue May 28, 2024 · 1 comment
Labels
enhancement New feature or request triage Add this label to issues that should be triaged and prioretized in the next planning call

Comments

@Itxaka
Copy link
Member

Itxaka commented May 28, 2024

Part 2 of #2200

While we now should be checking the EFI signature to confirm it can boot, we are not checking if the measurements of the EFI file are able to unlock the encrypted parts.

we should try to add this as it could lead to confusing errors in which you upgrade and boot, but then you cant unlock the partitions so you cannot log in (and apparently the system booted just fine)

The idea would be:

  • extract the .pcrsign section fo the efi file as text
  • use that to try and unlock the partition

problems:

  • if partitions are unlocked, can we check if the key is valid?
    • check systemd-cryptattach to see if its possible
    • check cryptsetup luksAddKey as that first tries to unlock?
@Itxaka Itxaka added enhancement New feature or request triage Add this label to issues that should be triaged and prioretized in the next planning call labels May 28, 2024
@ci-robbot
Copy link
Collaborator

To properly handle this issue, I will need more information. Could you please specify the versions of the artifacts you are using? This will help us to better understand the issue and provide a more accurate solution.

Please update the issue with the version information, and once that's done, the issue will be labeled as 'triage'.

I am a bot, an experiment of @mudler and @jimmykarily, auditing issues to ensure they meet the project's requirements. If you have any questions, feel free to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Add this label to issues that should be triaged and prioretized in the next planning call
Projects
Status: No status
Development

No branches or pull requests

2 participants