Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First point not rendered as mouse-over-able #879

Closed
akloeckner opened this issue Dec 2, 2022 · 7 comments
Closed

First point not rendered as mouse-over-able #879

akloeckner opened this issue Dec 2, 2022 · 7 comments
Labels
question Further information is requested released on @dev released

Comments

@akloeckner
Copy link
Collaborator

When we render a graph, the line is drawn for all coordinates (or, data points). But the first coordinate is not drawn as a point, i.e. the user cannot hover over the point and read its value.

Example following. Notice the missing small circle for the left-most data point. There should be 3 points. But only 2 are rendered.
image

Corresponding configuration:

type: custom:mini-graph-card
entities:
  - entity: sensor.haushalt_gasverbrauch
hours_to_show: 3
points_per_hour: 1
aggregate_func: mean
hour24: true
decimals: 2
smoothing: false
show:
  graph: line
  labels: false
  state: false

Judging from the following code line, it seems this first point is removed on purpose. Is that correct? If so: Why is that? If not: Should it be fixed?

coords.shift();

@github-actions
Copy link

🎉 This issue has been resolved in version 0.12.0-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ildar170975
Copy link
Collaborator

@akloeckner
The issue is associated with a PR which was merged.
Shall we close the issue?
Or this merged code is still in dev?

@akloeckner
Copy link
Collaborator Author

The merged code is still in dev. We have never merged dev into master. I think we should do that at the next occasion. The code is stable for multiple months now...

@ildar170975
Copy link
Collaborator

Then let's keep the issue open...

Copy link

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ildar170975
Copy link
Collaborator

@akloeckner
Seems to be fixed: the 1st point is shown as a "point":

image

type: custom:mini-graph-card
entities:
  - entity: sensor.xiaomi_cg_1_co2
hours_to_show: 3
points_per_hour: 1
aggregate_func: mean
hour24: true
decimals: 2
smoothing: false
show:
  graph: line
  points: true
  labels: false
  state: true

Shall we close?

@ildar170975 ildar170975 added the question Further information is requested label Jan 27, 2024
@akloeckner
Copy link
Collaborator Author

Yes! I thought, the issue would have been closed automatically....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested released on @dev released
Projects
None yet
Development

No branches or pull requests

2 participants