Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: align environment parmas names #38

Merged
merged 2 commits into from
Dec 10, 2017
Merged

feat: align environment parmas names #38

merged 2 commits into from
Dec 10, 2017

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Dec 3, 2017 •
edited
Loading

Description of the Changes

align with kaltura BE naming convention
beUrl => serviceUrl
baseUrl => cdn url

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe
feat: align environment parmas names
070cf91 
align with kaltura BE naming convention
beUrl => serviceUrl
baseUrl => cdn url
@OrenMe OrenMe self-assigned this Dec 3, 2017
@OrenMe OrenMe requested a review from yairans December 3, 2017 19:47
@OrenMe OrenMe merged commit 78f5a64 into master Dec 10, 2017
@OrenMe OrenMe deleted the envParamsNames branch December 10, 2017 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees

@OrenMe OrenMe

Labels
Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrenMe @yairans