Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7828): Live videos in OTT show VOD UI #49

Merged
merged 2 commits into from
Feb 12, 2018
Merged

fix(FEC-7828): Live videos in OTT show VOD UI #49

merged 2 commits into from
Feb 12, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Feb 12, 2018 •
edited
Loading

Description of the Changes

Fix the logic of checking live entry on OTT.
Now we're checking whether the response contains externalIds or its type of KalturaLinearMediaAsset.
Logic is similar to SDK logic

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Feb 12, 2018
@dan-ziv dan-ziv merged commit d19c46a into master Feb 12, 2018
@dan-ziv dan-ziv deleted the extends-live-ott-logic branch February 12, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@itaykinnrot itaykinnrot Awaiting requested review from itaykinnrot

Assignees

@dan-ziv dan-ziv

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe