Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 'networkRetryParameters' type causes KalturaPlayerJS build (flow) to fail #69

Merged
merged 3 commits into from
Nov 19, 2018
Merged

fix: 'networkRetryParameters' type causes KalturaPlayerJS build (flow) to fail #69

merged 3 commits into from
Nov 19, 2018

Conversation

odedhutzler
Copy link
Contributor

Description of the Changes

fix flow type impact KalturaPlayerJS.
add missing retryNetwork configuration.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler
fix flow issues + add network docs
99f95fe 
fix flow issues
networkRetryParameters?: ProviderNetworkRetryParameters,
impacting kalturaPlayer
@odedhutzler
Merge branch 'master' of https://github.com/kaltura/playkit-js-providers
bf51c7b 
 into flow_and_documentation
@odedhutzler odedhutzler self-assigned this Nov 19, 2018
@odedhutzler odedhutzler changed the title fix: 'networkRetryParameters' type cause KalturaPlayerJS build to fail fix: 'networkRetryParameters' type causes KalturaPlayerJS build to fail Nov 19, 2018
@odedhutzler odedhutzler changed the title fix: 'networkRetryParameters' type causes KalturaPlayerJS build to fail fix: 'networkRetryParameters' type causes KalturaPlayerJS build (flow) to fail Nov 19, 2018
OrenMe
OrenMe suggested changes Nov 19, 2018
View reviewed changes
src/k-provider/ott/provider.js Outdated Show resolved Hide resolved
@odedhutzler odedhutzler merged commit 6c67907 into master Nov 19, 2018
@odedhutzler odedhutzler deleted the flow_and_documentation branch November 19, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@odedhutzler odedhutzler

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odedhutzler @OrenMe