Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-8739): block action is not fired from OTT provider #71

Merged
merged 5 commits into from
Dec 4, 2018

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Dec 2, 2018

Description of the Changes

OTT BE rule action enum is a string equal to BLOCK while in OVP it is an int equal to 1.
We are currently using a base enum, which is incorrect as the enums are different, so need to separate the enum.
I also moved the base provider parser utility functions to more appropriate places, as having a base with shared enums between providers is not manageable.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

dan-ziv
dan-ziv previously approved these changes Dec 3, 2018
yairans
yairans previously approved these changes Dec 3, 2018
@OrenMe OrenMe dismissed stale reviews from yairans and dan-ziv via 2874ae2 December 4, 2018 12:50
@OrenMe OrenMe merged commit 2a318db into master Dec 4, 2018
@OrenMe OrenMe deleted the FEC-8739 branch December 4, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants