Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql-inspector-github fails to run due to "Cannot read property 'setFailed' of undefined" #1056

Closed
adam-h opened this issue Jan 10, 2020 · 4 comments
Milestone

Comments

@adam-h
Copy link

adam-h commented Jan 10, 2020

When running graphql-inspector-github on v1.27.0 I get the following error:

> ./node_modules/.bin/graphql-inspector-github
(node:39191) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'setFailed' of undefined
    at /home/adam/git/frontend/node_modules/@graphql-inspector/actions/dist/index.js:7:20

From poking around in dist/index.js changing:

core_1.default.setFailed(e.message || e);

to

core_1.setFailed(e.message || e);

Makes it move forward, a similar change in run.js gets me further. It seems like something is broken in the TS -> JS build around the default import.

Reverting to 1.25.0 works for me. I tried both Node 12 and Node 13, locally and in GitHub actions.

@kamilkisiela
Copy link
Owner

#1372 Should fix it

@kamilkisiela kamilkisiela added the ⏳ waiting for release This issue or pull request is waiting to be released label Apr 7, 2020
@kamilkisiela kamilkisiela added this to the 1.30.0 milestone Apr 7, 2020
@kamilkisiela
Copy link
Owner

v1.30.1

@kamilkisiela kamilkisiela removed the ⏳ waiting for release This issue or pull request is waiting to be released label Apr 8, 2020
@kamilkisiela
Copy link
Owner

Let me know if it's still an issue

@amandapouget
Copy link

Couldn't be more specific than "the answer is in this 25k line PR".

LOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants