Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I text glitches fix #2153

Merged
merged 4 commits into from
Apr 29, 2015
Merged

I text glitches fix #2153

merged 4 commits into from
Apr 29, 2015

Conversation

asturur
Copy link
Member

@asturur asturur commented Apr 27, 2015

Solves bad file shifting when deleting multiple characters across newlines. (old bug)
fixes style disappearing if you add empty lines and then delete them (regression)
Solves the deleting of first word of itext. (old bug)

I noticed that in current version the double click and triple click are not working anymore on chrome browser. Firefox is ok. it works

Current bug: style leaks on empty chars:
Go on kitchensink, delete the line between "dolor" and "sit Amet"m then press spacebar.
The style of "Amet" leaks on the space between "sit" and "Amet"

Some other fixes possible, do not merge, leave here for inspection.

@asturur
Copy link
Member Author

asturur commented Apr 27, 2015

@sapics
Copy link
Contributor

sapics commented Apr 28, 2015

@asturur Thank you for many fixes!

I would like to report other bug.
I push key [Delete] between [o] and [l], then, [o] becomes green from black.
now fixed!
http://giphy.com/gifs/3oEdv4LKyddQWRXisU

@asturur
Copy link
Member Author

asturur commented Apr 28, 2015

ahahah so ashamed!
thanks i ll fix it.

@asturur
Copy link
Member Author

asturur commented Apr 28, 2015

removed the automatic advance of cursor on newlines.
For me it does not feel natural ( also because we use it on one way and not going back ).

We can still put it back.

@sapics
Copy link
Contributor

sapics commented Apr 29, 2015

I confirmed fixed! Thanks!

I would like to confirm about keydown behavior.

  1. When cursor is between [ipsum]'s [u] and [m].
    Press [keydown].
    Then the cursor is between [dolor]'s [o] and [r].
    For me, the cursor will be end of [dolor] looks natural.
    http://giphy.com/gifs/l41lQovMQh7TQszE4
  2. When the cursor is at top of [iorem] or between [iorem]'s [i] and [o].
    Press [keydown].
    Then the cursor is end of line.
    For me, the cursor will be next line top looks natural.
    http://giphy.com/gifs/l41lQuvlcYBv5C3io

@asturur
Copy link
Member Author

asturur commented Apr 29, 2015

Fixed cursor movement (the error came because before the function was working on the text , now is working on textlines that do not include newlines and so we had a character less)
@kangax I think we are good to merge now.
@sapics thanks for keeping an eye next to mine

kangax added a commit that referenced this pull request Apr 29, 2015
@kangax kangax merged commit 91897de into fabricjs:master Apr 29, 2015
@asturur asturur deleted the iTextGlitch branch May 3, 2015 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants