Update shadow.class.js #2568
Update shadow.class.js #2568
Conversation
add affectStroke to toObject
| @@ -162,6 +163,9 @@ | |||
| if (this.offsetY !== proto.offsetY) { | |||
| obj.offsetY = this.offsetY; | |||
| } | |||
| if (this.affectStroke !== proto.affectStroke) { | |||
| obj.affectStroke = this.affectStroke; | |||
| } | |||
| return obj; | |||
There was a problem hiding this comment.
I think it's time to replace it with this :)
['color', 'blur', 'offsetX', 'offsetY', 'affectStroke'].forEach(function(prop) {
if (this[prop] !== proto[prop]) {
obj[prop] = this[prop];
}
}, this);There was a problem hiding this comment.
i do not understand why just this class has this feature.
There was a problem hiding this comment.
That's a very good question! What happens if we remove this chunk completely?
There was a problem hiding this comment.
That we have to remove some tests as well, and that we have to wait for 2.0 i think.
I would merge it and make a checklist for 2.0 to remove some old things.
|
@asturur actually let's wait with this until we merge promises branch; otherwise we'll have tons of conflicts |
|
Basically promises will conflict with any open PR. What do you think? |
|
Good idea, please add that label to this one! On Wed, Oct 21, 2015 at 7:24 AM, Andrea Bogazzi [email protected]
|
|
I think you are the only one that can create labels. |
|
Hm, you don't have "New label" button here? https://github.com/kangax/fabric.js/labels |
|
@kangax merge this for 1.6.0 release |
add affectStroke to toObject.
@kangax do you think that we should modify also _toString method?
we need test for this, before you say that :)
closes #2566