Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean polygon class #2627

Merged
merged 2 commits into from
Dec 27, 2015
Merged

Clean polygon class #2627

merged 2 commits into from
Dec 27, 2015

Conversation

asturur
Copy link
Member

@asturur asturur commented Nov 16, 2015

Remove _applyPointOffset that i introduced while ago and is totally bad.

Mainly because it change the original point array and makes difficult to add additional points to the polygon.

Need to fix SVG method.

@asturur
Copy link
Member Author

asturur commented Nov 16, 2015

Also there was a never triggered bug:
Points where changed in first render. But if we initialized the polygon and then executed the toSVG without going for a render, this would output a wrong polygon.

@asturur
Copy link
Member Author

asturur commented Nov 16, 2015

i noticed two unfixed shadow test. my fault.

@kangax
Copy link
Member

kangax commented Dec 3, 2015

i noticed two unfixed shadow test. my fault.
so... no merge yet?

@asturur
Copy link
Member Author

asturur commented Dec 3, 2015

i uploaded the fix in some pr. maybe we just need to relaunch the tests.
Il 03/dic/2015 19:35, "Juriy Zaytsev" [email protected] ha scritto:

i noticed two unfixed shadow test. my fault.
so... no merge yet?


Reply to this email directly or view it on GitHub
#2627 (comment).

@asturur
Copy link
Member Author

asturur commented Dec 3, 2015

we have 3 failing tests:

this from opacity pr

Module: fabric.Group Test: set objects' value should be set properly at Object. (/home/travis/build/kangax/fabric.js/test/unit/group.js:130:23) Actual value: 1 Expected value: 0.12345

those failing in nodejs but not in browser.

Module: fabric.Group Test: test group transformMatrix at Object. (/home/travis/build/kangax/fabric.js/test/unit/group.js:524:11) Actual value: true Expected value: false

Module: fabric.Group Test: test group transformMatrix at Object. (/home/travis/build/kangax/fabric.js/test/unit/group.js:528:11) Actual value: true Expected value: false

@asturur
Copy link
Member Author

asturur commented Dec 26, 2015

any thought on this?

kangax added a commit that referenced this pull request Dec 27, 2015
@kangax kangax merged commit 7235f36 into fabricjs:master Dec 27, 2015
@asturur asturur deleted the clean-polygon branch January 3, 2016 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants