Target in group

[asturur]

updated version of #2729

closes #485
closes #2998
closes #3005

[asturur]

Needs:

• TESTS
• add mouseover mouseout for subtargets (maybe separate PR)
• regression checks
• check strange behaviour with ITEXT ( it gets editables in active group)

DONE:

• passing also subtargets to events on canvas (maybe yes don't want to spam too much events)

[asturur]

mouseover mouseout for subtargets will be made in a separate PR.
This pr has mouse up, mouse down, mouse move.

There should be no problem implementing something like that, but becase now we use _hoveredTarget and we must change to a chain of hoverd targets, i need to take some time to choose best way.

[samuelhorwitz]

In order to better support subclassing, this would make more sense as target instanceof fabric.Group

[samuelhorwitz]

Does Fabric expect nested grouping? addWithUpdate inside of a nested group breaks. I'm looking into that now on my branch also but is that a regression or a known state of affairs with regards to groups?

[asturur]

Groups can be nested. If not we fix it.
are you able to reproduce the bug with a small fiddle?

[samuelhorwitz]

Yeah, here is a code pen.

http://codepen.io/anon/pen/bpXyQM

Sorry for cluttering this issue, it came up with my work off this PR but then I realized it was actually going back to Fabric before any of these changes.

EDIT Here is a pen with a solution I found http://codepen.io/anon/pen/yOmWww It removes the group from it's parent, then adds stuff to itself, then adds itself back to it's parent. Not the most beautiful solution, but points to the issue being with nested coordinate systems most likely

[asturur]

Nesting group will be topic of another PR. I need to keep changes small, independent, revertable, understandable.

Does the subtargeting work in group of groups?

[samuelhorwitz]

Yes, subtargeting works fine in groups of groups

[NikitaPirat]

Hi,
thanks a lot for your work! Could you say when will be the next release? I hope this fix will be there.

Thanks

[helia19s]

The subTargetCheck feature only works for Groups not pathgroup. I tried to fix it my self but the problem is the path position in a group is incorrect when we have scale and angle. I'm working with svg image and I need help . will it get fixed in next releases ?

[asturur]

no. pathgroups are completely different, are not meant for group/ungrouping, they are harder to handle due to transform matrix.
There is a PR open, blocked from some rounding issue in positioning that aims at removing path-groups to have just groups.
I'm not expanding any path-group feature since the idea is to remove them.