Update shiftKey & altKey values during __onMouseMove() #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from a stale mouseDown event
|
it creates a little inconsistency because with rotation we cannot do that for some weird reason. |
|
I m guessing if that hardCoded shiftKey is a missed |
asturur
pushed a commit
that referenced
this pull request
Dec 2, 2016
…from a stale mouseDown event (#3479)
|
hmm. I got that shiftKey reference from here: https://github.com/kangax/fabric.js/blob/52013a94d18a6c6ce6ead426176ce8709c6c7ccb/src/canvas.class.js#L625 should that also use the uniScaleKey? |
|
not before a full read of what is there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the values of
shiftKey&altKeyare set on mouseDown and only the cached values are referenced during mouseMove events. This means if you start a transform and then want to holdalttocenterTransformyou can't until you stop transforming and holdaltbefore starting the transform.This change updates the values during mouseMove which lets you start a transform and add the key modifier on the fly.