Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Replace "dsl" query parameters with "dsl" property in "/v2/integrations" #682

Closed
lordrip opened this issue May 31, 2023 · 0 comments
Closed
Labels
enhancement New feature or request java Pull requests that update Java code Never stale Prevent stale bot from closing this issue
Milestone

Comments

@lordrip
Copy link
Contributor

lordrip commented May 31, 2023

Context

Currently, we're using the /v2/integrations endpoint as follows:

http://localhost:8081/v2/integrations?dsl=Kamelet

And at the same time, we're sending the dsl type in the Integration object.

    {
      "id": "Kamelet-1460075016",
      "dsl": "Kamelet", <---
      "description": "",
      "metadata": {
        "description": "",
        "dsl": { <---
          "validationSchema": "/v1/capabilities/Kamelet/schema",
          ...
        },

Goal

The goal of this issue is to use the dsl property from a single place, this place should be the root dsl string property, as the others are likely sent by mistake from the UI

    {
      "id": "Kamelet-1460075016",
      "dsl": "Kamelet", <--- THIS ONE
      "description": "",
      "metadata": {
        "description": "",
        "dsl": {
          "validationSchema": "/v1/capabilities/Kamelet/schema",
          ...
        },

Notes

Given that the UI has been sending the dsl property already for a while, this change may not require a bump in the endpoint version.

@lordrip lordrip added enhancement New feature or request Never stale Prevent stale bot from closing this issue java Pull requests that update Java code labels May 31, 2023
@lordrip lordrip added this to the 1.1.0 milestone May 31, 2023
@lordrip lordrip closed this as completed Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request java Pull requests that update Java code Never stale Prevent stale bot from closing this issue
Projects
None yet
Development

No branches or pull requests

1 participant