Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Step Detail: Hide Config tab if no properties exist #1271

Closed
kahboom opened this issue Feb 16, 2023 · 0 comments · Fixed by #1658
Closed

Step Detail: Hide Config tab if no properties exist #1271

kahboom opened this issue Feb 16, 2023 · 0 comments · Fixed by #1658
Labels
bug Something isn't working good first issue Good for newcomers step detail Relates to the step detail view

Comments

@kahboom
Copy link
Contributor

kahboom commented Feb 16, 2023

Describe the Bug

When you click on a step that has no properties or parameters to configure, you still are shown a blank Config tab, which is confusing, especially because it's the default tab.

Steps to Reproduce the Bug or Issue

  1. Open Kaoto, go to Settings
  2. Change DSL to Kamelet
  3. Add kamelet:source step
  4. Click on it to open the Step Detail view
  5. See the blank Config tab

Screenshots or Videos

Screen Shot 2023-02-16 at 6 43 06 pm

Platform

This happens regardless of platform/browser/version.

Suggested Solution

This needs to be fixed from the VisualizationStepViews component. There is currently a check for whether parameters exists for the step, but it happens from within the tab. We should conduct this check to conditionally render the tab.

@kahboom kahboom added bug Something isn't working good first issue Good for newcomers labels Feb 16, 2023
@kahboom kahboom added the step detail Relates to the step detail view label Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers step detail Relates to the step detail view
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant