extend Http class to be able to set a hook

[tstanczak]

Creating a Http request from Java is easy and comfortable yet doesn't expose all possibilities of the underlying HttpRequestBuilder, like the ability to set a RuntimeHook.
There are workarounds, but already having a general hook it would be easier if being able to set on such manually created Http so that all http requests travel the same way.

[ptrthomas]

you mean the Java API, and the Http class, okay gotcha. to be honest most teams use the DSL. I recommend you submit a PR, it should be very straightforward, just add a couple methods on that class etc. we can guide.

[tstanczak]

Hi,
so I have extended Http and created a JUnit Test. Now how should I proceed? Is it preferred to make a branch of develop? Or is it irrelevant, if you accept the changes you would merge into develop anyway?

[tstanczak]

I guess I missed something - I need to fork first to be able to contribute...

[ptrthomas]

@tstanczak you can just add one or more methods to the existing Http class, don't bother extending it. see if our contributor guide helps: https://github.com/karatelabs/karate/blob/master/.github/CONTRIBUTING.md

[tstanczak]

Yes, the code does modify existing class and is ready and tested. It's just that I never used GitHub collaboration before, always worked in a corporation environment with enough access rights to just create a branch and push it into the original repository. Now I think the way to go is to create a fork, make a branch there and make a PR out of the fork. I'll do it after my daily work.
And before I do that I'll read your contributing guide :-) - thanks for pointing out!

[tstanczak]

I have just made a PR.

[ptrthomas]

@tstanczak merged with thanks 👍

[ptrthomas]

1.4.1 released