the @setup hook may not be compatible with dry-run

[ptrthomas]

as reported here: https://stackoverflow.com/q/76965130/143475

[adiChoudhary]

Hi,
I would love to work on this issue if its not already assigned.

[ptrthomas]

@adiChoudhary sure, you can provide a summary of how you want to solve this and then submit a PR

[adiChoudhary]

Ok mate, will provide the relevant details after going through the overall project within 2-4 days of time.

[codehackerr]

@ptrthomas can you assign this one to me, please ?

Analysis

Current code path does not execute setup steps in dry run mode.

Approach:

• The approach will be to identify if a step is a setup step and execute it even for a dryrun.
• Need modifications to ScenarioRuntime Scenario and Step
• Need a test case for dynamic examples with @setup scenario

[ptrthomas]

@codehackerr sure go ahead

[codehackerr]

Added test cases SetupDryRunTest for feature with setup in dry run mode.

• This error result is neither list nor function: [type: NULL, value: null] does not occur anymore.
• Scenarios are added in the test output for each example

[ptrthomas]

much appreciated @codehackerr - tagging @rc2201 as I think he reported this on stack-overflow

[ptrthomas]

karate 1.5.0.RC3 including this fix is now available

[rc2201]

I tested the changes and it returns the count now where @setup is being used. However full suite is being marked as failed.
This is happening for the all suites irrespective of usage of @setup. Earlier it was marked as passed.

Here are the screenshots showing everything marked as failed and confirming the release.

Error for all the scenario-
Cannot invoke "com.intuit.karate.core.Scenario.isSetup()" because "this.scenario" is null

StackTrace-
java.lang.NullPointerException: Cannot invoke "com.intuit.karate.core.Scenario.isSetup()" because "this.scenario" is null at com.intuit.karate.core.Step.isSetup(Step.java:231) at com.intuit.karate.core.ScenarioRuntime.execute(ScenarioRuntime.java:446) at com.intuit.karate.core.ScenarioRuntime.run(ScenarioRuntime.java:400) at com.intuit.karate.core.FeatureRuntime.processScenario(FeatureRuntime.java:195) at com.intuit.karate.core.FeatureRuntime$1.process(FeatureRuntime.java:142) at com.intuit.karate.core.FeatureRuntime$1.process(FeatureRuntime.java:138) at com.intuit.karate.core.ParallelProcessor.lambda$toRunnable$0(ParallelProcessor.java:59) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:840)

[codehackerr]

@rc2201 Thanks for testing this and finding the above issue!

I believe this is happening because of steps that are not under a scenario, like background. Will submit another PR.

[codehackerr]

@rc2201 I was able to reproduce the issue with a background step and that is fixed now. Could you please verify, if the above PR fixes the issue?

@ptrthomas FYI

[ptrthomas]

1.5.0 released