From f8005c6307d530c703f3db266f31e40d55049fb6 Mon Sep 17 00:00:00 2001 From: Ilya Goncharov Date: Thu, 10 Oct 2019 03:05:13 +0300 Subject: [PATCH] fix(runner): remove explicit error on all tests failed (#3369) * fix(runner): remove explicit error on all tests failed - there are failOnFailingTestSuite and failOnEmptyTestSuite, so in this there is no neccesity Fixes #3367 * test(unit): Remove test --- lib/browser.js | 4 ---- test/unit/browser.spec.js | 7 ------- 2 files changed, 11 deletions(-) diff --git a/lib/browser.js b/lib/browser.js index 1023194e8..20fd93d0b 100644 --- a/lib/browser.js +++ b/lib/browser.js @@ -87,10 +87,6 @@ class Browser { this.setState(CONNECTED) this.lastResult.totalTimeEnd() - if (!this.lastResult.success) { - this.lastResult.error = true - } - this.emitter.emit('browsers_change', this.collection) this.emitter.emit('browser_complete', this, result) diff --git a/test/unit/browser.spec.js b/test/unit/browser.spec.js index 2233cf93a..3c1113c09 100644 --- a/test/unit/browser.spec.js +++ b/test/unit/browser.spec.js @@ -213,13 +213,6 @@ describe('Browser', () => { expect(browser.lastResult.totalTime).to.equal(2) }) - - it('should error the result if zero tests executed', () => { - browser.state = Browser.STATE_EXECUTING - browser.onComplete() - - expect(browser.lastResult.error).to.equal(true) - }) }) describe('onDisconnect', () => {