Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karma run clientArgs persist between runs #2323

Closed
dcosson opened this issue Aug 18, 2016 · 1 comment
Closed

Karma run clientArgs persist between runs #2323

dcosson opened this issue Aug 18, 2016 · 1 comment

Comments

@dcosson
Copy link

dcosson commented Aug 18, 2016

Expected behavior

I have a karma already launched with a browser attached, karma start --run-once=false. Using karma-jasmine adapter.

I run:

karma run -- --grep=foo
karma run

I expect the first one to run just matching "foo" and the second to run all the tests.

Actual behavior

The second one just runs the "grep=foo" tests.

I went in and added logging in the entrypoints of the karma-jasmine adapter, and I see that window.__karma__.config still has args: ['--grep=foo'] on the second run.

Since it doesn't look like karma-jasmine ever sets this value, this seems like a bug in karma itself rather than in the framework adapter. Karma is not clearing window.__karma__ between runs.

Enviroment Details

  • Karma version (output of karma --version): 1.2.0
  • Relevant part of your karma.config.js file N/A

Steps to reproduce the behaviour

Described above

@EzraBrooks
Copy link
Collaborator

#2819 is a duplicate of this issue, but it has more details on the issue so I'm going to close this one instead. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants