Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TravisCI is failing on node <6 #2753

Closed
naganowl opened this issue Jun 28, 2017 · 1 comment
Closed

TravisCI is failing on node <6 #2753

naganowl opened this issue Jun 28, 2017 · 1 comment

Comments

@naganowl
Copy link

Expected behaviour

#2752 and #2747 only pass Travis for node 6.

Actual behaviour

They should pass on npm 6

Environment Details

The PRs are failing on validation of the commit message on older versions of npm, but succeeds on npm 6. The error message it outputs is

0.77s$ npm run init
0.09s$ if [ "$VALIDATE_COMMIT_MSG" == "true" ]; then npm run travis; else ./scripts/validate-commit-msg.sh $TRAVIS_COMMIT; fi
INVALID COMMIT MSG: does not match "<type>(<scope>): <subject>" !
/home/travis/build/karma-runner/karma/.git/COMMIT_EDITMSG
The command "if [ "$VALIDATE_COMMIT_MSG" == "true" ]; then npm run travis; else ./scripts/validate-commit-msg.sh $TRAVIS_COMMIT; fi" failed and exited with 1 during .

Steps to reproduce the behaviour

  1. https://travis-ci.org/karma-runner/karma/jobs/248146863
  2. https://travis-ci.org/karma-runner/karma/builds/244545086
@chrahunt
Copy link
Contributor

chrahunt commented Jul 9, 2017

The validation is not succeeding on 6, it is just not being done (since $VALIDATE_COMMIT_MSG is set to true).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants