Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seems to be an issue with return statements in _radd and _rmul inside engine.py #82

Open
reachpalaniv opened this issue Nov 15, 2024 · 1 comment

Comments

@reachpalaniv
Copy link

Based on the video, if I am not mistaken, _radd and _rmul are supposed to flip the return values to other+self.
the reverse function is to address the condition where a scalar precedes the operators

@AsmitPS
Copy link

AsmitPS commented Jan 19, 2025

When radd or rmul are called, they automatically interchange the data between self and other, so you don't need to explicitly reverse the operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants