-
Notifications
You must be signed in to change notification settings - Fork 177
Conversation
Otherwise this generates some js that uses eval and upsets csp
Codecov Report
@@ Coverage Diff @@
## master #1141 +/- ##
=======================================
Coverage 60.87% 60.87%
=======================================
Files 224 224
Lines 3737 3737
Branches 633 633
=======================================
Hits 2275 2275
Misses 1461 1461
Partials 1 1 Continue to review full report at Codecov.
|
build/webpack.config.js
Outdated
@@ -70,6 +70,9 @@ module.exports = { | |||
chunkFilename: 'assets/js/[id].[chunkhash].js', | |||
pathinfo: false, | |||
}, | |||
node: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also try node: false
and see if all dependencies cope with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok so far! It builds, and clicking around locally is ok. I'll push the change.
Nope, has an error. On https://deploy-preview-1141--karrot.netlify.com/ when trying to edit my profile.
Seems they should fix it, see vuelidate/vuelidate#365, but we can force it. I guess "web" is the correct value. |
This reverts commit f382689.
What does this PR do?
CSP is upset about eval, and apparantly if we make this change it'll be happy again :)
See webpack/webpack#6461 (comment)
Links to related issues
#1068
Checklist