Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Move inline style to static css file #1143

Merged
merged 1 commit into from
Nov 24, 2018
Merged

Move inline style to static css file #1143

merged 1 commit into from
Nov 24, 2018

Conversation

nicksellen
Copy link
Member

What does this PR do?

We had some inline style on the homepage for the splash landing. I moved this to an external file.

Links to related issues

#1068

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #karrot-dev channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, pull request link, username(s))

@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

Merging #1143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1143   +/-   ##
=======================================
  Coverage   60.87%   60.87%           
=======================================
  Files         224      224           
  Lines        3737     3737           
  Branches      620      633   +13     
=======================================
  Hits         2275     2275           
  Misses       1461     1461           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc07ed...30d0a21. Read the comment docs.

@nicksellen nicksellen merged commit 53b1e1a into master Nov 24, 2018
@nicksellen nicksellen deleted the avoid-inline-style branch November 24, 2018 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants