Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirm locale behaviour #382

Closed
gubuntu opened this issue Oct 10, 2018 · 17 comments
Closed

confirm locale behaviour #382

gubuntu opened this issue Oct 10, 2018 · 17 comments
Assignees
Labels
Milestone

Comments

@gubuntu
Copy link
Contributor

gubuntu commented Oct 10, 2018

@lucernae after #291 can you confirm whether InaSAFE headless, GeoSAFE and GeoNode switch locales between EN and PT based on user locale and that user can override?

And that other non-available languages are removed from locale options?

@lucernae
Copy link
Contributor

@gubuntu The way that it works:

  1. Browser will take language settings from the computer
  2. Django will take that settings and saves it on the cookie to remember it next time
  3. User can switch to language, even though it is different from their computer settings. This changes will be saved (currently the button is at the bottom).
  4. The whole text in site will rely in this settings to set language. The locales passed on to Headless will take from current user configurations (not implemented yet, but planned to behave like this). This allow you to create multiple report on different language on the same site.
  5. Non-available languages can be removed, yes. We will plan to remove non-available language from the theme app.

@lucernae lucernae added in review and removed ready labels Oct 11, 2018
@lucernae
Copy link
Contributor

Locale changes should be seen in the testing sites

@gubuntu
Copy link
Contributor Author

gubuntu commented Oct 16, 2018

yes I switched between pt and en nicely.

when should headless locale switching be implemented?

@gubuntu gubuntu added testing and removed in review labels Oct 16, 2018
@NyakudyaA
Copy link

@gubuntu I also could change between the languages nicely. We can close this

@gubuntu
Copy link
Contributor Author

gubuntu commented Oct 25, 2018

@NyakudyaA please test that text and map reports are also in ingc theme and in pt.

@NyakudyaA
Copy link

Yes I am currently running an analysis in PT

@myarjunar
Copy link
Contributor

myarjunar commented Oct 25, 2018

@gavin @NyakudyaA I'm still doing the last check and fix on custom template. I will let you know once it gets deployed.

@NyakudyaA
Copy link

Ok @myarjunar I have ran an analysis and if failed with some errors. I will create a new issue for it

@NyakudyaA
Copy link

I ran the analysis and the text and theme are still in the old GeoSAFE themes. Perhaps @myarjunar still busy fixing this as it relates to custom templates

@NyakudyaA
Copy link

NyakudyaA commented Nov 7, 2018

@myarjunar cc @lucernae the InaSAFE variables are not being substituted in the reports properly
screenshot 2018-11-07 at 08 56 50

The table report - has it been translated , it is only available in English ?.

@myarjunar
Copy link
Contributor

whoa, can you point me to the analysis page? @NyakudyaA

@NyakudyaA
Copy link

@lucernae
Copy link
Contributor

lucernae commented Nov 8, 2018

My bug sorry! It has been fixed in this commit: . :D
inasafe/inasafe-headless@2dccbe3

@NyakudyaA
Copy link

@myarjunar I assume the table will also be translated when a new InaSAFE is released. Otherwise, everything is working properly on this ticket.

@lucernae
Copy link
Contributor

The next step up is to include the table template in Django, so Django wil handle the template translation and generation (it doesn't have to rely on InaSAFE strings).

@gubuntu
Copy link
Contributor Author

gubuntu commented Nov 20, 2018

@lucernae can you put that in a new ticket (in Funnel) then close this one please

@NyakudyaA
Copy link

#502

@NyakudyaA NyakudyaA removed the testing label Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants