Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade to HEAD, i got this error. #243

Closed
markwu opened this issue Aug 19, 2019 · 5 comments
Closed

After upgrade to HEAD, i got this error. #243

markwu opened this issue Aug 19, 2019 · 5 comments
Labels

Comments

@markwu
Copy link

markwu commented Aug 19, 2019

I get this error only in macvim (8.1-1722), not in neovim HEAD.

Error detected while processing /Users/mark/.vim/bundle/neoterm/plugin/neoterm.vim:
line  136:
E216: No such group or event: TermOpen * call neoterm#new_from_event()
Press ENTER or type command to continue
@kassio
Copy link
Owner

kassio commented Aug 19, 2019

Sorry about that, I'll investigate it later today.

@kassio kassio added the MACVIM label Aug 19, 2019
@kassio kassio closed this as completed in 0e47652 Aug 19, 2019
@markwu
Copy link
Author

markwu commented Aug 20, 2019

Hi @kassio:

Thanks for fixing this problem, but I have a question about this feature.

It seems you plan to let neoterm manage all terminal open. What if I don't want neoterm to manage my specific terminal buffer? For example fzf.vim I use it for fuzzy finder like ctrlp.

I have the following mappings only for neoterm buffer, it works great before this feature:

augroup NeotermSetup
     autocmd!
     autocmd FileType neoterm tnoremap <silent> <buffer> <Esc> <C-\><C-N>
     autocmd FileType neoterm nmap <silent> <buffer> q :quit!<CR>
augroup END

With this TermOpen feature, neoterm will pollute my <esc> mapping in fzf buffer. It original maps to quit fzf buffer, instead of back to normal mode.

how do I avoid this happened? It's a little bit annoying. Can I have a buffer exclude list or something to avoid neoterm manage my specific terminal buffer?

Thanks, Mark

@kassio kassio reopened this Aug 20, 2019
@kassio
Copy link
Owner

kassio commented Aug 20, 2019

So, the intention was to be able to handle session saved terminals. I'll do some investigation and see how to accomplish that without messing with fzf and other types of terminals.

@kassio kassio closed this as completed in 64e861a Aug 20, 2019
@kassio
Copy link
Owner

kassio commented Aug 20, 2019

It shouldn't be a problem now, I'm scoping the TermOpen to handle only neoterm terminals.

@markwu
Copy link
Author

markwu commented Aug 20, 2019

It works great. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants