-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KDL 1.0 Compliance #6
Comments
I still wonder whether I should change the parser output to better support value tags, and in the future the query spec. Right now it's just a bunch of objects. Node tags could be another property, value tags could be handled based on user-supplied callbacks (or opt-in defaults) and queries could be loose functions taking the document as an argument. But I could also make classes. |
I mean I think as long as you're parsing the spec, it's fine to throw away tags, in general? Though for kdljs itself it might be good to just shove that metadata into a |
Maybe |
How would that look then? {
node: 'foo',
values: [1, 2],
properties: { foo: 'bar' },
type: {
name: 'node-tag',
values: [null, 'i32'],
properties: { foo: 'url' }
}
} |
that doesn't look too shabby if you're willing to expose your guts. It might be nice for kdljs to start supporting stuff through queries, though? And just plain methods instead of just giving you a whole structure? |
I released |
( |
I think that's good enough for me if you want to close this issue! The other stuff can come later :) |
Hi! Since this was originally written, KDL has stabilized to 1.0.0. No further changes should be made to spec so it should be safe to update + finalize kdljs to the 1.0 spec!
Please let me know if you have any questions or if there's anything I can do to help!
The text was updated successfully, but these errors were encountered: