Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TargetPendingRequests not respected on HTTPScaledObjects #234

Closed
arschles opened this issue Aug 19, 2021 · 0 comments · Fixed by #242
Closed

TargetPendingRequests not respected on HTTPScaledObjects #234

arschles opened this issue Aug 19, 2021 · 0 comments · Fixed by #242
Labels
bug Something isn't working

Comments

@arschles
Copy link
Collaborator

arschles commented Aug 19, 2021 •
edited
Loading

After #206, you can set targetPendingRequests on a HTTPScaledObject, but it isn't respected if it's different from the default.

Expected Behavior

The external scaler returns that target to KEDA when requested

Actual Behavior

The external scaler always returns 100

Steps to Reproduce the Problem

  1. Check out the branch for PR Multi-tenant interceptor and scaler #206
  2. Install the chart from PR feat: multi-tenant scaler and interceptor in the HTTP add-on charts#169
  3. Create a new HTTPScaledObject with a targetPendingRequests of 200
  4. Observe that a new ScaledObject is created
  5. Observe that the scaler's GetMetricSpec RPC call always returns 100 for that ScaledObject

Specifications
@arschles arschles added the bug Something isn't working label Aug 19, 2021
@arschles arschles mentioned this issue Aug 26, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specifying target in scaler for specific host arschles/http-add-on
1 participant
@arschles