Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for HTTP redirect responses to the interceptor #249

Closed
arschles opened this issue Sep 1, 2021 · 3 comments · Fixed by #258
Closed

Add tests for HTTP redirect responses to the interceptor #249

arschles opened this issue Sep 1, 2021 · 3 comments · Fixed by #258
Labels
Milestone

Comments

@arschles
Copy link
Collaborator

arschles commented Sep 1, 2021

The interceptor uses the standard library's single host reverse proxy. This proxy should handle HTTP redirect responses automatically, but a test should be added to the interceptor to ensure that is the case, and the redirects are processed properly.

The client of the interceptor should not see evidence of the redirect.

@arschles
Copy link
Collaborator Author

@yaron2 we discussed this offline. in your opinion, should the interceptor handle redirections? As expected, the standard library's reverse proxy code doesn't follow redirects. I don't think we should have the interceptor follow them either, because it should be left up to the client how to react to a 302, 301, or similar. Maybe one exception to this could be to follow redirects to other internal microservices.

WDYT?

@yaron2
Copy link

yaron2 commented Sep 21, 2021

I'm fine not supporting redirects and gather feedback if this is needed.

@arschles
Copy link
Collaborator Author

Thanks @yaron2 for letting me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants