Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus: queryParameters is an optional parameter #1394

Closed
zroubalik opened this issue May 20, 2024 Discussed in #1391 · 0 comments · Fixed by #1395
Closed

Prometheus: queryParameters is an optional parameter #1394

zroubalik opened this issue May 20, 2024 Discussed in #1391 · 0 comments · Fixed by #1395

Comments

@zroubalik
Copy link
Member

Discussed in #1391

Originally posted by ahinh43 May 15, 2024
I'm working on upgrading our Keda deployment from 2.11 to 2.14, and one of the changes introduced in 2.13 is the queryParameters field for the prometheus scaler. However, it's documented as a required field yet in the source code the field is marked optional.

My initial impression of reading the trigger specifications
is that missing fields under required fields would result in the request being rejected during an apply but I could be misunderstanding this.

Is there any implications for not setting queryParameters in a prometheus trigger's metadata field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant