Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide trigger authentication support for GCP scalers #1273

Closed
RealHarshThakur opened this issue Oct 19, 2020 · 2 comments
Closed

Provide trigger authentication support for GCP scalers #1273

RealHarshThakur opened this issue Oct 19, 2020 · 2 comments
Labels
auth scaler-gcp-pub-sub

Comments

@RealHarshThakur
Copy link
Contributor

RealHarshThakur commented Oct 19, 2020 •
edited by tomkerkhove
Loading

GCP should support TriggerAuthentication like other scalers

Use-Case

This is more secure

Would be happy to take this issue up with little guidance.
I see that gcp scaler is reading auth creds from config.TriggerMetadata . So if I change it to read from config.Auth , will it just work or are there any other changes that I would need to do?
@RealHarshThakur RealHarshThakur added feature-request All issues for new features that have not been committed to needs-discussion labels Oct 19, 2020
@RealHarshThakur RealHarshThakur mentioned this issue Oct 19, 2020
Merged
@tomkerkhove
Copy link
Member

We are certainly open for contributions @harshthakur9030, thanks for the suggestion!

Adding @zroubalik for guidance

@tomkerkhove tomkerkhove added auth scaler-gcp-pub-sub and removed needs-discussion feature-request All issues for new features that have not been committed to labels Oct 20, 2020
@tomkerkhove tomkerkhove changed the title GCP TriggerAuth Provide trigger authentication support for GCP scalers Oct 20, 2020
@zroubalik
Copy link
Member

I see that gcp scaler is reading auth creds from config.TriggerMetadata . So if I change it to read from config.Auth , will it just work or are there any other changes that I would need to do?

I think this should do the job :)

@RealHarshThakur RealHarshThakur mentioned this issue Oct 25, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auth scaler-gcp-pub-sub
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zroubalik @tomkerkhove @RealHarshThakur