Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show min/max replica count when using kubectl get scaledobject #1410

Closed
tomkerkhove opened this issue Dec 11, 2020 · 8 comments · Fixed by #1534
Closed

Show min/max replica count when using kubectl get scaledobject #1410

tomkerkhove opened this issue Dec 11, 2020 · 8 comments · Fixed by #1534
Labels
feature-request All issues for new features that have not been committed to needs-discussion operations

Comments

@tomkerkhove
Copy link
Member

Show minimum replica count when using kubectl get scaledobject.

Use-Case

This allows operators to easily learn what the replica counts are for scaled objects.

@tomkerkhove tomkerkhove added needs-discussion feature-request All issues for new features that have not been committed to operations labels Dec 11, 2020
@Ritikaa96
Copy link
Contributor

Hi @tomkerkhove are we adding the min/max? is this going forward?

@Ritikaa96
Copy link
Contributor

Ritikaa96 commented Jan 25, 2021

I had tweaked with the code to get these before so if it is going forward I can raise the pr.
If this is what I think it is.

@tomkerkhove
Copy link
Member Author

We are certainly open for a PR if you want to contribute this @Ritikaa96 - Thanks!

@Ritikaa96
Copy link
Contributor

Sure, thanks @tomkerkhove ! so to be certain we have to add minReplicaCount and maxReplicaCount both right? Like:

kubectl get so

NAME ...... **MINREPLICACOUNT** **MAXREPLICACOUNT** READY ACTIVE AGE
scaledObjectName ....... **1** **30** TRUE TRUE .....

@tomkerkhove
Copy link
Member Author

I'd go for MIN REPLICAS | MAX REPLICAS - OK for you @zroubalik ?

@zroubalik
Copy link
Member

I'd go for MIN REPLICAS | MAX REPLICAS - OK for you @zroubalik ?

@tomkerkhove yeah, I like this

@Ritikaa96
Copy link
Contributor

@tomkerkhove @zroubalik Great then, I'll change the column-names to MIN REPLICAS & MAX REPLICAS and raise the PR.

@Ritikaa96
Copy link
Contributor

@tomkerkhove @zroubalik adding MIN | MAX for both scaledObject and scaledJob cases in #1534 FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion operations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants