Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and cleanup metric names inside scalers #2191

Closed
JorTurFer opened this issue Oct 13, 2021 · 0 comments · Fixed by #2260 or kedacore/keda-docs#576
Closed

Review and cleanup metric names inside scalers #2191

JorTurFer opened this issue Oct 13, 2021 · 0 comments · Fixed by #2260 or kedacore/keda-docs#576
Assignees
@JorTurFer
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Milestone
v2.5.0

Comments

@JorTurFer
Copy link
Member

Proposal

After #2123, we can ensure that metric names are unique inside ScaledObject. Before it, we used several mechanism inside scalers to avoid conflicts in metric names (like adding part of masked connectionString) those are not needed right now.
IMHO, we should review all scalers and remove those mechanisms. This will clear the code, unify how we are calculating metric names, and reduce risks related with exposing secrets

Use-Case

No response

Anything else?

No response
@JorTurFer JorTurFer added feature-request All issues for new features that have not been committed to needs-discussion labels Oct 13, 2021
@zroubalik zroubalik added this to the v2.5.0 milestone Nov 8, 2021
This was referenced Nov 8, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JorTurFer JorTurFer

Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

Cleanup metric names inside scalers JorTurFer/keda
docs: Cleanup metric names inside scalers
2 participants
@zroubalik @JorTurFer