Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed Identity based authentication for the azure-pipelines scaler #4072

Closed
guidooliveira opened this issue Jan 5, 2023 · 13 comments
Closed
Labels
feature-request All issues for new features that have not been committed to help wanted Looking for support from community needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@guidooliveira
Copy link

Proposal

Would it be possible to add support or a handler for the scaler to use a managed identity (when running on Azure) to either request a PAT token and use it transparently or to use the Bearer authentication for that. This would make having the PAT token storage(and associated rotation/management) optional, and make the usage a bit more seamless.

Use-Case

For Self-Hosted agents in AKS for example we need to generate a PAT token and store that (preferably in a secure way) and manage the expiration and possible leakage of the said token. for registering the scaler in the Node Pool.

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

@guidooliveira guidooliveira added feature-request All issues for new features that have not been committed to needs-discussion labels Jan 5, 2023
@JorTurFer
Copy link
Member

Hi,
Sadly, it's not possible atm because the Azure Pipelines API doesn't support it, the only authentication method supported is the PAT. Once AzPipelines team release another mechanism, we can include it

@stale
Copy link

stale bot commented Mar 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Mar 6, 2023
@tomkerkhove
Copy link
Member

Hi, Sadly, it's not possible atm because the Azure Pipelines API doesn't support it, the only authentication method supported is the PAT. Once AzPipelines team release another mechanism, we can include it

Closing this issue for now because of the above. Feel free to re-open in the future once this is supported.

@tomkerkhove tomkerkhove closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2023
@github-project-automation github-project-automation bot moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Mar 7, 2023
@JorTurFer JorTurFer moved this from Ready To Ship to Done in Roadmap - KEDA Core Mar 13, 2023
@davidharkis
Copy link

Support for Managed Identities on Azure DevOps is now in public preview

@JorTurFer JorTurFer reopened this Apr 7, 2023
@github-project-automation github-project-automation bot moved this from Done to Proposed in Roadmap - KEDA Core Apr 7, 2023
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Apr 7, 2023
@guidooliveira
Copy link
Author

Amazing!

@davidzenisu
Copy link

Awesome, would love to see that feature soon.
Together with federated workload identities (testing that out right now) this would completely remove PATs from our KEDA agent configurations!

@tomkerkhove
Copy link
Member

@JorTurFer What do you think? Are you still using ADO at Lidl?

@JorTurFer
Copy link
Member

JorTurFer commented Apr 21, 2023

Yes we do, and we have had a problem with an expired PAT this week xD
I think this feature is really useful and we should add it. In tandem with the support (from MSFT) in the agent side, the PATs can be totally removed.
I'm not sure if our infra is ready for it or we need to dome something else as we were talking by slack, but we should try to add the required infra and support it

@stale
Copy link

stale bot commented Jun 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jun 20, 2023
@JorTurFer JorTurFer added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Jun 20, 2023
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Jun 20, 2023
@JorTurFer JorTurFer added help wanted Looking for support from community stale All issues that are marked as stale due to inactivity labels Jun 20, 2023
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Jun 20, 2023
@phmcder
Copy link

phmcder commented Dec 10, 2023

This looks like it relates to #4853 and #5013

@antiphon0
Copy link

antiphon0 commented Dec 29, 2023

+1 to this, just ran into having to replace the PAT by editing the secret in the cluster, which isn't the end of the world - that said, it'd be nice to just not have to worry about it at all. I know the DevOps API is weird with auth, though I think I was able to get my Function App to authenticate with the DevOps API using a managed identity, so I'd think something similar should be possible. https://medium.com/@relente/using-system-managed-identity-to-invoke-azure-devops-rest-api-7833bc988705

@rbnmk
Copy link

rbnmk commented Jan 22, 2024

+1 For this feature. Would love to get rid of PATs at all ouf our clients for Self Hosted agent scenarios on AKS/Container Apps

@JorTurFer
Copy link
Member

This feature has been already merged and shipped as part of v2.13, so I close the issue

@github-project-automation github-project-automation bot moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to help wanted Looking for support from community needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Archived in project
Development

No branches or pull requests

8 participants