Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Storage Queue scaling up to invisible messages #4432

Closed
jellevankerk opened this issue Apr 3, 2023 · 6 comments
Closed

Azure Storage Queue scaling up to invisible messages #4432

jellevankerk opened this issue Apr 3, 2023 · 6 comments
Labels
bug Something isn't working stale All issues that are marked as stale due to inactivity

Comments

@jellevankerk
Copy link

Report

I use the Azure Storage Queue scaler for processes that need to run more that 5 minutes, which means that queue can look 'empty' (invisible messages) for a long time. with the fix from #4003, keda keeps scaling up pods while the queue being 'empty'.

Expected Behavior

keda to only scale down based on the invisible + visible messages and scale up based on only the visible messages

Actual Behavior

keda scales down based on the invisible + visible messages and scale up based on invisible + visible messages

Steps to Reproduce the Problem

  1. Create a scaledjob with a storage queue as a trigger and pollingInterval 30
  2. Send a message in the storage queue

Logs from KEDA operator

example

KEDA Version

2.10.0

Kubernetes Version

1.24

Platform

Microsoft Azure

Scaler Details

Azure Storage Queue

Anything else?

No response

@jellevankerk jellevankerk added the bug Something isn't working label Apr 3, 2023
@JorTurFer
Copy link
Member

Hi,
But in the other case, you'd remove the instances processing messages yet, I mean, now with that fix the HPA controller doesn't kill pods if they are still processing messages. How were you ensuring that the HPA controller didn't kill the extra pods before the change?

@tomkerkhove
Copy link
Member

He is using scaled job so HPA is not applicable here and jobs will just run.

@tomkerkhove tomkerkhove moved this from To Triage to To Do in Roadmap - KEDA Core Apr 26, 2023
@tomkerkhove
Copy link
Member

I get why this is not ideal for your scenario, but I'm not sure I agree on your expected behavior though. Either we incorporate invisible+visible for both scale out/in, or we incorporate only visible; but not a combination based on scale in or out.

@tomkerkhove
Copy link
Member

Created #4478 which is related

@stale
Copy link

stale bot commented Jun 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jun 25, 2023
@stale
Copy link

stale bot commented Jul 2, 2023

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Jul 2, 2023
@github-project-automation github-project-automation bot moved this from To Do to Ready To Ship in Roadmap - KEDA Core Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale All issues that are marked as stale due to inactivity
Projects
Archived in project
Development

No branches or pull requests

3 participants