Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP Scalers: Add support for custom time horizon #5453

Closed
JorTurFer opened this issue Feb 1, 2024 · 2 comments · Fixed by #5778
Closed

GCP Scalers: Add support for custom time horizon #5453

JorTurFer opened this issue Feb 1, 2024 · 2 comments · Fixed by #5778
Labels
feature-request All issues for new features that have not been committed to help wanted Looking for support from community

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Feb 1, 2024 •
edited
Loading

Proposal

As part of this fix, we have set the time horizon for the gcp client to 2m. Current values are hardcoded (2m and 5m). As this is something that users would want to modify based on their requirements, we should support setting it from scaler metadata
@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Feb 1, 2024
@JorTurFer JorTurFer mentioned this issue Feb 1, 2024
Merged
1 task
@stale Stale
Copy link

stale bot commented Apr 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Apr 1, 2024
@zroubalik zroubalik added help wanted Looking for support from community and removed needs-discussion stale All issues that are marked as stale due to inactivity labels Apr 10, 2024
@Yaxhveer
Copy link
Contributor

Yaxhveer commented May 3, 2024

Working on this.

@Yaxhveer Yaxhveer mentioned this issue May 3, 2024
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to help wanted Looking for support from community
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added custom time horizon in GCP scaler Yaxhveer/keda
3 participants
@zroubalik @JorTurFer @Yaxhveer