Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parameter vhostName in TriggerAuthentication #6369

Open
michemache opened this issue Nov 27, 2024 · 3 comments · May be fixed by #6373
Open

Support parameter vhostName in TriggerAuthentication #6369

michemache opened this issue Nov 27, 2024 · 3 comments · May be fixed by #6373
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity

Comments

@michemache
Copy link

Proposal

The TriggerAuthentication resource should also support the parameter vhostName, as the Virtual host can be part of the host URL, but it doesn't have to. To fully cover the possible connection parameters, it would be nice to have that option.

Use-Case

If you have all the parameters individually, you don't need to assemble the host URL in advance.

Is this a feature you are interested in implementing yourself?

Maybe

Anything else?

No response
@michemache michemache added feature-request All issues for new features that have not been committed to needs-discussion labels Nov 27, 2024
@JorTurFer
Copy link
Member

Hello
Do you mean RabbitMQ's scaler vhostName? I guess that we can support it. Are you willing to open a PR?

@michemache
Copy link
Author

Hi Jorge,
Yes, I mean the RabbitMQ scaler vhostName.
I will try to open a PR.

@michemache michemache linked a pull request Nov 28, 2024 that will close this issue
Open
4 tasks
@stale Stale
Copy link

stale bot commented Jan 27, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity
Projects
Roadmap - KEDA Core
Status: To Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use RabbitMQ vhostName from authParams when declared michemache/keda
2 participants
@michemache @JorTurFer