Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS support to artemis scaler #6448

Open
sambou90 opened this issue Dec 30, 2024 · 3 comments · May be fixed by #6474
Open

Add TLS support to artemis scaler #6448

sambou90 opened this issue Dec 30, 2024 · 3 comments · May be fixed by #6474
Assignees
@chiragbhatia8
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@sambou90
Copy link

Proposal

It looks like the ActiveMQ Artemis scaler does not support TLS. The http:// is hardcoded in the constant value defaultRestAPITemplate: https://github.com/kedacore/keda/blob/main/pkg/scalers/artemis_scaler.go#L52

It would be nice if there is the same possibility like in the ActiveMQ Scaler: https://github.com/kedacore/keda/blob/main/pkg/scalers/activemq_scaler.go#L50

Otherwise it seems like it is not possible to use TLS for secure connection.

Use-Case

Use scaler ActiveMQ Artemis with TLS for secure connection.

Is this a feature you are interested in implementing yourself?

Maybe

Anything else?

No response
@sambou90 sambou90 added feature-request All issues for new features that have not been committed to needs-discussion labels Dec 30, 2024
@zroubalik
Copy link
Member

Makes sense, are you willing to contribute this?

@chiragbhatia8
Copy link

Hey @zroubalik would love to take a stab at it.

@chiragbhatia8 chiragbhatia8 mentioned this issue Jan 9, 2025
Closed
7 tasks
chiragbhatia8 added a commit to chiragbhatia8/keda that referenced this issue Jan 9, 2025
@chiragbhatia8
feat(scaler): Add TLS support for Artemis scaler
b40d166 
Initial implementation for TLS support in Artemis Scaler.
Issue: kedacore#6448

Signed-off-by: Chirag Bhatia <[email protected]>
@chiragbhatia8 chiragbhatia8 linked a pull request Jan 9, 2025 that will close this issue
Open
7 tasks
chiragbhatia8 added a commit to chiragbhatia8/keda that referenced this issue Jan 9, 2025
@chiragbhatia8
feat(scaler): Update the HTTP and HTTPS endpoint to use natsStreaming…
4a7322a 
…HTTPProtocol/natsStreamingHTTPSProtocol

Issue: kedacore#6448

Signed-off-by: Chirag Bhatia <[email protected]>
chiragbhatia8 added a commit to chiragbhatia8/keda that referenced this issue Jan 13, 2025
@chiragbhatia8
feat(scaler): Remove unnecessary leading newline
4bbc51a 
Issue: kedacore#6448

Signed-off-by: Chirag Bhatia <[email protected]>
@chiragbhatia8
Copy link

@zroubalik Please review this PR for adding TLS support to the Artemis scaler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chiragbhatia8 chiragbhatia8

Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Status: To Triage
Milestone
No milestone
3 participants
@zroubalik @chiragbhatia8 @sambou90