From b382b082442b7c02a43cf3fec27dad2b1096ad00 Mon Sep 17 00:00:00 2001 From: Shubham Kuchhal Date: Fri, 4 Jun 2021 17:39:16 +0530 Subject: [PATCH 1/3] Show HashiCorp Vault Address when using Kubectl get ta or kubectl get cta Signed-off-by: Shubham Kuchhal --- api/v1alpha1/triggerauthentication_types.go | 2 ++ config/crd/bases/keda.sh_clustertriggerauthentications.yaml | 3 +++ config/crd/bases/keda.sh_triggerauthentications.yaml | 3 +++ 3 files changed, 8 insertions(+) diff --git a/api/v1alpha1/triggerauthentication_types.go b/api/v1alpha1/triggerauthentication_types.go index 964f69bce3e..6dc4b695baf 100644 --- a/api/v1alpha1/triggerauthentication_types.go +++ b/api/v1alpha1/triggerauthentication_types.go @@ -13,6 +13,7 @@ import ( // +kubebuilder:printcolumn:name="PodIdentity",type="string",JSONPath=".spec.podIdentity.provider" // +kubebuilder:printcolumn:name="Secret",type="string",JSONPath=".spec.secretTargetRef[*].name" // +kubebuilder:printcolumn:name="Env",type="string",JSONPath=".spec.env[*].name" +// +kubebuilder:printcolumn:name="VaultAddress",type="string",JSONPath=".spec.hashiCorpVault.address" type ClusterTriggerAuthentication struct { metav1.TypeMeta `json:",inline"` metav1.ObjectMeta `json:"metadata,omitempty"` @@ -37,6 +38,7 @@ type ClusterTriggerAuthenticationList struct { // +kubebuilder:printcolumn:name="PodIdentity",type="string",JSONPath=".spec.podIdentity.provider" // +kubebuilder:printcolumn:name="Secret",type="string",JSONPath=".spec.secretTargetRef[*].name" // +kubebuilder:printcolumn:name="Env",type="string",JSONPath=".spec.env[*].name" +// +kubebuilder:printcolumn:name="VaultAddress",type="string",JSONPath=".spec.hashiCorpVault.address" type TriggerAuthentication struct { metav1.TypeMeta `json:",inline"` metav1.ObjectMeta `json:"metadata,omitempty"` diff --git a/config/crd/bases/keda.sh_clustertriggerauthentications.yaml b/config/crd/bases/keda.sh_clustertriggerauthentications.yaml index 4e95110c14d..0340c9074a7 100644 --- a/config/crd/bases/keda.sh_clustertriggerauthentications.yaml +++ b/config/crd/bases/keda.sh_clustertriggerauthentications.yaml @@ -29,6 +29,9 @@ spec: - jsonPath: .spec.env[*].name name: Env type: string + - jsonPath: .spec.hashiCorpVault.address + name: VaultAddress + type: string name: v1alpha1 schema: openAPIV3Schema: diff --git a/config/crd/bases/keda.sh_triggerauthentications.yaml b/config/crd/bases/keda.sh_triggerauthentications.yaml index 63eebeeb9c4..6984c0a2454 100644 --- a/config/crd/bases/keda.sh_triggerauthentications.yaml +++ b/config/crd/bases/keda.sh_triggerauthentications.yaml @@ -29,6 +29,9 @@ spec: - jsonPath: .spec.env[*].name name: Env type: string + - jsonPath: .spec.hashiCorpVault.address + name: VaultAddress + type: string name: v1alpha1 schema: openAPIV3Schema: From 760d078c2dcdadaa60faca49655166e042572bae Mon Sep 17 00:00:00 2001 From: Shubham Kuchhal Date: Fri, 4 Jun 2021 20:20:16 +0530 Subject: [PATCH 2/3] Update the Changelog. Signed-off-by: Shubham Kuchhal --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 514674e17d9..64dea491c4d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,6 +26,7 @@ ### Improvements - Fix READY and ACTIVE fields of ScaledJob to show status when we run `kubectl get sj` ([#1855](https://github.com/kedacore/keda/pull/1855)) +- Show HashiCorp Vault Address when using `kubectl get ta` or `kubectl get cta` ([#1862](https://github.com/kedacore/keda/pull/1862)) ### Breaking Changes From 8e261749fab97ec359feaa723b4f16ce9fe31524 Mon Sep 17 00:00:00 2001 From: Shubham Kuchhal Date: Sat, 5 Jun 2021 10:31:19 +0530 Subject: [PATCH 3/3] Correct the Changelog. Signed-off-by: Shubham Kuchhal --- CHANGELOG.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 64dea491c4d..bf8a45335b0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,12 +21,11 @@ ### New -- TODO ([#XXX](https://github.com/kedacore/keda/pull/XXX)) +- Show HashiCorp Vault Address when using `kubectl get ta` or `kubectl get cta` ([#1862](https://github.com/kedacore/keda/pull/1862)) ### Improvements - Fix READY and ACTIVE fields of ScaledJob to show status when we run `kubectl get sj` ([#1855](https://github.com/kedacore/keda/pull/1855)) -- Show HashiCorp Vault Address when using `kubectl get ta` or `kubectl get cta` ([#1862](https://github.com/kedacore/keda/pull/1862)) ### Breaking Changes