-
Notifications
You must be signed in to change notification settings - Fork 40
A better way to define Service ports #19
Comments
Will this not make tooling difficult and perhaps induce string magic? |
You are overwriting already existing 'ports'. We can use a shortcut like this, but it has to be named differently. Something that is not already in ServiceSpec |
Yes, the tooling will be difficult but that is an implementation detail that we can take care of. @kadel -
Agree, we can have a different field name for this, we can carry the services:
- name: wordpress
type: LoadBalancer
portsRef:
- 8080:80/udp
ports:
- port: 8080
targetPort: 80
protocol: UDP
|
That is definitely not what we discussed in the meeting. To quote from the meeting logs that you yourself noted:
Strong -1 to this idea. |
|
Just be aware that it is quite common that "easy to tool" and "easy for humans" are opposite. |
@kadel -
Yep, in OpenCompose we decided to use |
@pradeepto - everything in #2 required string magic. Doing string magic is going to let us create shortcuts to add better UX to the spec. It's not about string magic, it's about better UX for the spec, which is the prime goal right now. I'm fine with not doing string magic if there is a better way of implementing this, any suggestions? |
@containscafeine @kadel Whatever you guys decide, keep integrations (LSP bits etc) in the mind. If we can integrate with existing tooling (vscode, che) with less or no effort that is a HUGE win. Saves time and wins hearts. That is all I am saying. |
I don't think we need this for now, let's reconsider if and when a need arises |
The way Kubernetes' ServiceSpec allows describing Ports is something like this -
We can also provide an alternative shortcut way to do this by using a syntax like -
The text was updated successfully, but these errors were encountered: