Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

generate openshift artifacts #210

Closed
3 tasks done
surajssd opened this issue Aug 8, 2017 · 8 comments
Closed
3 tasks done

generate openshift artifacts #210

surajssd opened this issue Aug 8, 2017 · 8 comments

Comments

@surajssd
Copy link
Member

surajssd commented Aug 8, 2017

Right now we only create artifacts which default to kubernetes, but we should also add artifacts for OpenShift as well.

The first thing that comes to my mind is adding a flag similar to kompose called --provider. And generating things which are different in OpenShift like DeploymentConfig, if we add support for builds in kedge then support for BuildConfig.

@kadel
Copy link
Member

kadel commented Aug 9, 2017

Let's skip discussions about BuildConfig, that is going to be whole another discussion.

I can see two options how we can add OpenShift support.
First one is adding flag as @surajssd described (i would use --distribution as it might be a better name than --provider - OpenShift is distribution of Kubernetes)

The second option is to have two binaries. Something like kedge-k8s and kedge-openshift. Rationale for this is that almost no one is using both. You deploy to plain Kubernetes or to OpenShift, but usually not to both. Then why complicate this by adding another flag that OpenShift users will have to always remember set. This will make it little less complicated for users as all its required is to download a right binary. User doesn't have to worry about providing right flag.

@concaf concaf added this to the 0.2.0 milestone Aug 10, 2017
@pradeepto
Copy link
Member

@kadel @surajssd Does this issue need to be scoped out better than "generate resources". But what after that? kedge deploy should be able to work with oc instead of kubectl. WDTY?

@aslakknutsen
Copy link

@kadel One consumer that needs both k8 and os is fabric8. It could download both binaries of course.. but

@pradeepto
Copy link
Member

Chatted with @aslakknutsen just now. He says that his use case requires DeploymentConfig and Routes.

@pradeepto
Copy link
Member

Created smaller tasks for DeploymentConfig and Routes and linked them in the original description.

@kadel
Copy link
Member

kadel commented Sep 4, 2017

Created smaller tasks for DeploymentConfig and Routes and linked them in the original description.

The first smaller task should be introducing --distribution switch to allow switching between k8s and OpenShift.

@kadel
Copy link
Member

kadel commented Sep 4, 2017

We also need to support multiple OpenShift versions similarly to #141

@kadel kadel removed this from the 0.2.0 milestone Sep 4, 2017
@kadel kadel added the kind/epic label Sep 4, 2017
@cdrage
Copy link
Collaborator

cdrage commented Nov 27, 2017

Routes have been added now: #238

Can we close @surajssd ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants