imagePullSecrets are dropped on the floor

[snoby]

While generating a template that used imagePullSecrets I determined that the kedge templating engine drops the "imagePullSecrets" on the floor and doesn't bring them over to the final rendered output.
The debug output is of very little use
the template:

name: sparky
labels:
  app: sparky
replicas: 1
containers:
- name: sparky
  image: sparkb/sparky:UNKNOWN_VERSION
  imagePullSecrets:
    - name: dockerhub-key
  livenessProbe:
    httpGet:
      path: /liveness
      port: 10009
  readinessProbe:
    httpGet:
      path: /ready
      port: 10009
  resources:
    limits:
      cpu: 500m
      memory: 256Mi
    requests:
      cpu: 300m
      memory: 128Mi

the output result:

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    app: sparky
  name: sparky
spec:
  replicas: 1
  strategy: {}
  template:
    metadata:
      creationTimestamp: null
      labels:
        app: sparky
      name: sparky
    spec:
      containers:
      - image: sparkbo/sparky:UNKNOWN_VERSION
        livenessProbe:
          httpGet:
            path: /liveness
            port: 10009
        name: sparky
        readinessProbe:
          httpGet:
            path: /ready
            port: 10009
        resources:
          limits:
            cpu: 500m
            memory: 256Mi
          requests:
            cpu: 300m
            memory: 128Mi
status: {}

This along with the lack of passing annotations limits the effectiveness of this potentially wonderful tool!

[surajssd]

@snoby thanks for trying out kedge.

imagePullSecrets is a pod level field, not a container level field. So please modify the yaml to look like this:

name: sparky
labels:
  app: sparky
replicas: 1
containers:
- name: sparky
  image: sparkb/sparky:UNKNOWN_VERSION
  livenessProbe:
    httpGet:
      path: /liveness
      port: 10009
  readinessProbe:
    httpGet:
      path: /ready
      port: 10009
  resources:
    limits:
      cpu: 500m
      memory: 256Mi
    requests:
      cpu: 300m
      memory: 128Mi
imagePullSecrets:
- name: dockerhub-key

And now run generate, it will generate it for you.

$ kedge generate -f file.yaml 
---
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    app: sparky
  name: sparky
spec:
  replicas: 1
  strategy: {}
  template:
    metadata:
      creationTimestamp: null
      labels:
        app: sparky
      name: sparky
    spec:
      containers:
      - image: sparkb/sparky:UNKNOWN_VERSION
        livenessProbe:
          httpGet:
            path: /liveness
            port: 10009
        name: sparky
        readinessProbe:
          httpGet:
            path: /ready
            port: 10009
        resources:
          limits:
            cpu: 500m
            memory: 256Mi
          requests:
            cpu: 300m
            memory: 128Mi
      imagePullSecrets:
      - name: dockerhub-key
status: {}

HTH 🙂

[snoby]

AH yes indeed. I thought I had tried that. Man guys just get annotations to work and it's exactly the tool I need!!!!!
Thank you

[surajssd]

Man guys just get annotations to work and it's exactly the tool I need!!!!!

We are in discussion of how do we add support of annotations!

@containscafeine you might wanna link this as a feature request from user!

[kadel]

Mistakes like this should be cached by Kedge. This goes back to #168
We should start working on solving this.

[surajssd]

ping @surajnarwade