Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Move to using kedge schema structs in kedge init #324

Open
surajssd opened this issue Oct 10, 2017 · 4 comments
Open

Move to using kedge schema structs in kedge init #324

surajssd opened this issue Oct 10, 2017 · 4 comments

Comments

@surajssd
Copy link
Member

Right now we use golang templates, so we should think of moving to using kedge schema a.k.a. structs that kedge has defined. Golang templates tend to get complex very soon. With structs we can add more features and have easier control on what is to be generated.

@kadel
Copy link
Member

kadel commented Oct 10, 2017

When we start doing more complex generation it might become a bit complex with templates, I agree.

The thing is that we actually lose control over what is generated if we start serializing Kedge schema. For example, we lose ability to add comments.
The idea was that generated Kedge file should also contain some comments when we start doing a little bit more than just image and ports.

@kadel
Copy link
Member

kadel commented Oct 10, 2017

I'm marking this as a low priority. What we have is working right now. We can start thinking about this once it becomes an issue, or we need add more stuff to kedge init

@surajnarwade
Copy link
Collaborator

@surajssd @kadel Now we have golang structs in kedge init instead of templates, shall we close this ?

@surajssd
Copy link
Member Author

surajssd commented Feb 9, 2018

we are using golang structs but not kedge schema structs yet

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants