Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

e2e test invocation script passes even if test fails #348

Closed
surajssd opened this issue Oct 13, 2017 · 3 comments · Fixed by #364
Closed

e2e test invocation script passes even if test fails #348

surajssd opened this issue Oct 13, 2017 · 3 comments · Fixed by #364

Comments

@surajssd
Copy link
Member

This is leading to false positives. See logs of run from https://semaphoreci.com/cdrage/kedge/branches/pull-request-297/builds/6

Script says it passed even if the e2e test failed:

...
0:30484: dial tcp 192.168.99.100:30484: getsockopt: connection refused
    	e2e_test.go:213: error while making http request "http://192.168.99.100:30484" for service "wordpress:8080", err: Get http://192.168.99.100:30484: dial tcp 192.168.99.100:30484: getsockopt: connection refused
    	e2e_test.go:213: error while making http request "http://192.168.99.100:30484" for service "wordpress:8080", err: Get http://192.168.99.100:30484: dial tcp 192.168.99.100:30484: getsockopt: connection refused
    	e2e_test.go:213: error while making http request "http://192.168.99.100:30484" for service "wordpress:8080", err: Get http://192.168.99.100:30484: dial tcp 192.168.99.100:30484: getsockopt: connection refused
    	e2e_test.go:213: error while making http request "http://192.168.99.100:30484" for service "wordpress:8080", err: Get http://192.168.99.100:30484: dial tcp 192.168.99.100:30484: getsockopt: connection refused
    	e2e_test.go:218: "wordpress:8080" is running!
    	e2e_test.go:451: Successfully pinged all endpoints!
    	e2e_test.go:237: successfully deleted namespace: "customvol"
FAIL
exit status 1
FAIL	github.com/kedgeproject/kedge/tests/e2e	801.607s
envfrom   database-541265016-g35hw   0/1       Terminating   0         59s
envfrom   database-541265016-g35hw   0/1       Terminating   0         59s
./tests/e2e/run_e2e.sh: line 45: kill: (14695) - No such process
@surajssd
Copy link
Member Author

@ashetty1 do you mind looking at this?

@ashetty1
Copy link
Collaborator

@surajssd the customvol tests have succeeded and have been marked as PASS, while --- FAIL: Test_Integration/Normal_Wordpress_test has FAILed. What exactly needs to be investigated?

@surajssd
Copy link
Member Author

@ashetty1 the tests failed, but still the test invocation script exits with status 0, rather it should also fail!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants