-
Notifications
You must be signed in to change notification settings - Fork 40
Add support for BuildConfig and ImageStreams #385
Comments
The only problem with root level bc is that how do we tell it which container it should build for if pod has multiple containers? |
Because the amount of information in your proposal, someone has to give is way too much and I think some of it can be auto generated/populated if we put/embed the buildconfigspec inside containerspec |
That is defined inside BuildConfig. See output section in BuildConfig definition. DeploymentConfig is hooked to that ImageStream so it triggers deployment what IS changes |
This is the typical way how it is done in OpenShift. We need to support this either way. |
BuildConfig should be a new type in Kedge file.
We should do it the same way as other types. Merging
BuildConfigSpec
withObjectMeta
and adding it under new root level keybuildconfigs
This will also require adding ImageStreams in the same way (merging
ImageStreamSpec with
ObjectMeta`.full example of Kedge file with BuildConfig (using cusom s2i) and ImageStreams:
imageStreams
definetly has to be list. But how aboutbuildConfigs
? Does it make sense to have multiple buildConfig if we can have only one controller in one file (or one section of the file).It might make sense to have only one buildConfig to stay consistent with one controller.
The text was updated successfully, but these errors were encountered: