Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create URL parameters for each element/section in kedro-viz #1117

Closed
1 task done
Huongg opened this issue Oct 4, 2022 · 1 comment · Fixed by #1138
Closed
1 task done

Create URL parameters for each element/section in kedro-viz #1117

Huongg opened this issue Oct 4, 2022 · 1 comment · Fixed by #1138
Assignees
Labels
Issue: Feature Request Javascript Pull requests that update Javascript code

Comments

@Huongg
Copy link
Contributor

Huongg commented Oct 4, 2022

Description

Parameters are placeholders in the URL that begin with a colon.

Context

With this feature, every time user clicks on a node in the flowchart, or a run in the experiment tracking, it will reflect on the URL, for example:
https://demo.kedro.org/experiment-tracking/run-id
or
https://demo.kedro.org/flowchart/selected:modular_pipeline_id (we would need to think and agree on the path for workflow as its more complicated than the experiment tracking

Once we have this URL parameter, we can do other things such as store the path in local storage so when the user re-enters the URL, it will open where it was left before, or it can also be helpful for this idea here

Possible Implementation

This can be achieved using React router (which we already have in our kedro-viz). Since there will be a lot of different paths, maybe best if we can have routes.config in which we define different path like this

export const routes = {
  flowchart: {
      main: '/flowchart',
      selectedModularPipeline: '/flowchart/selected:modular_pipeline_id',
      focusedModularPipeline: '/flowchart/focused:modular_pipeline_id',
      selectedDataset: '/flowchart/selected:dataset_id',
    },
   experimentTracking: {
   .....
   }
}

Checklist

  • Include labels so that we can categorise your feature request
@Huongg Huongg added Issue: Feature Request Javascript Pull requests that update Javascript code labels Oct 4, 2022
@Huongg Huongg self-assigned this Oct 5, 2022
@tynandebold
Copy link
Member

I'm not sure we'd want to include /flowchart actually, as I think that would constitute a breaking change.

@Huongg Huongg mentioned this issue Oct 19, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request Javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants