Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "DataSet" with "Dataset" in Kedro-Datasets #2751

Closed
deepyaman opened this issue Jul 3, 2023 · 1 comment · Fixed by kedro-org/kedro-plugins#328
Closed

Replace "DataSet" with "Dataset" in Kedro-Datasets #2751

deepyaman opened this issue Jul 3, 2023 · 1 comment · Fixed by kedro-org/kedro-plugins#328
Assignees
@deepyaman @merelcht
Milestone
Package kedro.ext...

Comments

@deepyaman
Copy link
Member

deepyaman commented Jul 3, 2023 •
edited by merelcht
Loading

Description

In the spirit of consistency, we should first deprecate, later rename, datasets with the "DataSet" spelling (as already done in Kedro). This should also include docs updates.

This should not replace references to core "DataSet" versions (e.g. AbstractDataSet) yet, because that would break compatibility with older Kedro.

Possible implementation

Naive way:

Possible alternative
@deepyaman deepyaman added the Issue: Feature Request New feature or improvement to existing feature label Jul 3, 2023
@deepyaman deepyaman mentioned this issue Jun 29, 2023
Closed
6 tasks
@astrojuanlu
Copy link
Member

Should we move this to kedro-plugins ?

@merelcht merelcht removed the Issue: Feature Request New feature or improvement to existing feature label Jul 31, 2023
@merelcht merelcht added this to the Renaming DataSet -> Dataset milestone Jul 31, 2023
@github-actions github-actions bot mentioned this issue Aug 18, 2023
Closed
@merelcht merelcht self-assigned this Sep 4, 2023
@merelcht merelcht linked a pull request Sep 5, 2023 that will close this issue
refactor(datasets): deprecate "DataSet" type names kedro-org/kedro-plugins#328
Merged
4 tasks
@merelcht merelcht mentioned this issue Sep 1, 2023
Closed
9 tasks
@merelcht merelcht mentioned this issue Sep 18, 2023
Closed
@deepyaman deepyaman mentioned this issue Sep 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepyaman deepyaman

@merelcht merelcht

Labels
None yet
Projects
None yet
Milestone
Package kedro.extras.datasets into it...
Development

Successfully merging a pull request may close this issue.

refactor(datasets): deprecate "DataSet" type names kedro-org/kedro-plugins
3 participants
@astrojuanlu @deepyaman @merelcht