Importing kedro.runners enables Rich logging

[astrojuanlu]

Description

Context

Steps to Reproduce

1. Do a logging.warning("ANY MESSAGE") on a notebook to see that it's formatted as plain text
2. import kedro.runners
3. Repeat logging.warning("ANY MESSAGE") and observe the formatting has changed

Expected Result

Actual Result

I didn't expect imports to have such side effects.

Also, I don't think there's a way to revert it: Textualize/rich#2461 so I need to resort to hacks.

[merelcht]

I've done some digging and the issue at first seems to come from the import:from kedro.framework.hooks.manager import _NullPluginManager. But then I moved that out and I got some more info when doing import kedro.runner:

[07/05/24 14:50:03] INFO     Using                                                                  [__init__.py](file:///Users/Merel_Theisen/anaconda3/envs/kedro/lib/python3.11/site-packages/kedro/framework/project/__init__.py):[246](file:///Users/Merel_Theisen/anaconda3/envs/kedro/lib/python3.11/site-packages/kedro/framework/project/__init__.py#246)
                             '/Users/Merel_Theisen/anaconda3/envs/kedro/lib/python3.11/site-package                
                             s/kedro/framework/project/rich_logging.yml' as logging configuration.

So it seems that logging is configured when you import the runner. I've also checked that this doesn't happen when importing e.g. DataCatalog or the configloaders.

It seems that this comes from the ParallelRunner where we directly import LOGGING which triggers the logging configuration
I tested this by removing ParallelRunner completely and the references to it in kedro.runner.__init__.py and can see that rich doesn't get triggered when it's all removed.

It looks like it comes from:

kedro/kedro/runner/parallel_runner.py

Lines 19 to 24 in a179f87

	from kedro.framework.hooks.manager import (
	_create_hook_manager,
	_register_hooks,
	_register_hooks_entry_points,
	)
	from kedro.framework.project import settings

Which flows into:

kedro/kedro/framework/hooks/specs.py

Line 9 in a179f87

from kedro.framework.context import KedroContext

to:

kedro/kedro/framework/context/context.py

Line 16 in a179f87

from kedro.framework.project import settings

which seems to lead to:

kedro/kedro/framework/project/__init__.py

Line 266 in a179f87

LOGGING = _ProjectLogging()

So it turns out it is both the import to _NullPluginManager as well as the imports inside ParallelRunner to hooks and project settings. Eventually it all boils down to the logging being configured when project settings are imported.

[astrojuanlu]

Fixing this issue is very difficult, the code is quite nested, and we prefer to wait until we tackle the root cause of the issues we have with rich, see #3967 (comment)

I'm leaving this open for visibility but we aren't doing anything about it for now. If somebody finds an easy way to fix it, PRs welcome.